Don't give a hard error if we can't determine the fingerprint for a custom toolchain #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyn514
commented
Jul 29, 2022
|
@holmgr would it be possible to take a look at this PR? Ever since I've installed cargo-sweep I cannot use the |
jyn514
force-pushed
the
custom-toolchains
branch
from
dc435a6
to
2b94056
Compare
|
@elpiel FYI I am the current maintainer of cargo-sweep. I plan to add tests for cargo-sweep before I merge this, since it has a lot of functionality and I've never used more than one or two flags. See #63 (comment). |
jyn514
force-pushed
the
custom-toolchains
branch
2 times, most recently
from
a8c4ba1
to
dfb2e90
Compare
…ustom toolchain Previously, cargo sweep would unconditionally give an error when it couldn't determine the fingerprint. But for custom toolchains, it makes sense for it to be linked but give an error when you try to run it: it means the compiler hasn't yet been built. Rather than aborting straight away, treat the toolchain as if it isn't installed and clean its artifacts.
jyn514
force-pushed
the
custom-toolchains
branch
from
dfb2e90
to
b04b419
Compare
|
Awesome! 🚀 |
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, cargo sweep would unconditionally give an error when it couldn't determine the
fingerprint. But for custom toolchains, it makes sense for it to be linked but give an error when
you try to run it: it means the compiler hasn't yet been built.
Rather than aborting straight away, treat the toolchain as if it isn't installed and clean its artifacts.
This also gives a significantly better error message if cargo-sweep can't determine the fingerprint (which can still happen in practice if you've managed to really mess up one of your toolchains). Before:
After:
Fixes #65.