Fix/android build #1
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use platform-specific CMakeLists.txt used for building iwasm binary. Building iwasm also builds the libraries we are linking to and it appears to be the only method supported for building on all the platforms.
I'm still having an inconsistent issue where cmake complains that WAMR_BUILD_TARGET is not set -- seems to happen every other run. I'm guessing there is some cmake cache from the prior run that is not getting cleared properly.
With this setup, and some changes to the nix environment, android builds are working.
I'm guessing this will make win32 builds work as well, but need to test.
It sounds like this work may get merged into wasmer's 5.x release, so perhaps we can wait for that.