Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated nyc_buildings #199

Closed
wants to merge 2 commits into from
Closed

Updated nyc_buildings #199

wants to merge 2 commits into from

Conversation

jbednar
Copy link
Contributor

@jbednar jbednar commented Apr 21, 2022

Updated nyc_buildings to use higher res, have a dashboard, and explain more. At least on my Mac Retina display, the default PlotSize.scale made the output much blockier than it needed to be. The datashader-rendered polygons are now just as sharp as the Bokeh-rendered overlay:

image

Issues:

  • I added a non-categorical plot at the start, and it seems a lot faster to render than the categorical plot. Is that expected to be unavoidable?
  • I want the dashboard to be responsive to the browser tab screen size, but I have no idea how to convince it to do that. If you know, please fix this and update Added FAQ about sharing only a single axis holoviz/holoviews#5278 .

@jbednar jbednar requested a review from philippjfr April 21, 2022 18:27
@jlstevens
Copy link
Contributor

I wonder how common retina displays (or equivalent) are nowadays. I suspect we might want to up the PlotSize.scale everywhere in holoviews and tell people how to lower it rather than raise it. That would be for holoviews 2.0 though...

@jbednar
Copy link
Contributor Author

jbednar commented Apr 25, 2022

For Polygon, TriMesh, Area, Raster, and QuadMesh, I agree. Because those plot types have a spatial extent, a finer grid for sampling them is always a win (at some cost in speed and document size).

However, for Points and non-antialiased lines, a finer resolution can make them much more difficult to see. The results when using points spreading and line spreading or antialiasing can look great with the increased resolution, but without one of those two mechanisms for making the item have a spatial extent, the additional resolution can be a big problem. So I'm not sure if we can move to a higher default PlotSize scale unless we also update everything to have a spatial extent.

@Azaya89
Copy link
Collaborator

Azaya89 commented May 23, 2024

This example is being worked on here #386

@maximlt
Copy link
Contributor

maximlt commented May 24, 2024

Ok thanks @Azaya89, please come back and comment on this PR when you have made more progress on #386. Make sure you have a look at the content of this PR, and the comments from Jim, to see what you can incorporate/improve/answer to.

@Azaya89
Copy link
Collaborator

Azaya89 commented Jun 7, 2024

I've incorporated most of the changes here into #386, although the PR is not finished yet.

Azaya89 pushed a commit that referenced this pull request Jun 14, 2024
@Azaya89 Azaya89 mentioned this pull request Jun 14, 2024
33 tasks
@droumis droumis closed this Jun 19, 2024
Azaya89 pushed a commit that referenced this pull request Aug 21, 2024
@maximlt maximlt deleted the nycb2 branch October 8, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants