Adding glasbey colormaps #25
Conversation
There was a problem hiding this comment.
Thanks for hitting this home! I have a few suggestions below, plus:
- I think we don't need to explicitly state "no_black" in any of the names, because all of them are "no_black" if I followed it correctly.
- Are you using the modified glasbey.py and passing
--min_chroma=10? I think that's important, or else there are a lot of gray colors included. If not, maybe add those and call themno_gray, and make those the default versions for which to use the short names.
After that I'm ready to merge and start using these!
| "cell_type": "markdown", | ||
| "metadata": {}, | ||
| "source": [ | ||
| "In addition to these long form names, colorcet provides several aliases to the most useful of the glasbey colormaps. These include - `glasbey`, `Category10`, and `Category20`. `Category10` and `Category20` can be used as replacements for the bokeh colormaps of the same name since they start with the same sequence." |
There was a problem hiding this comment.
I have gotten feedback from colorcet users that using the same name as any common colormap from a different package causes confusion, so I think Category10 should be maybe gCategory10, and similarly for Category20. Yes, these colormaps are in a different namespace, but people have still had trouble...
Co-Authored-By: jsignell <[email protected]>
|
I think this is ready to go in @jbednar |
There was a problem hiding this comment.
Looks good. About to push changes to Glasbey_colors.ipynb, and then it's back over to you. I might rename Glasbey_Colors to Categorical.ipynb, maybe? And then the main User Guide index needs to be updated to point to it and remove the categorical ones from its lists.
Co-Authored-By: jsignell <[email protected]>
|
Also, should the code bits be moved to a new file in colorcet, imported from |
| swatch(*arg, **kwargs) for | ||
| arg in args]).cols(cols) | ||
|
|
||
| backends = hv.Store.loaded_backends() |
There was a problem hiding this comment.
@jlstevens , it would be nice if backends not loaded would simply not validate, to avoid having to have code like this that checks the loaded_backends. Maybe something that can go into this hv release?
jsignell
dismissed
jbednar’s stale review
Restructured to put continuous and categorical next to each other
Co-Authored-By: jsignell <[email protected]>
|
I built the website locally and it looks fine. |
|
Good to merge? |
Co-Authored-By: jsignell <[email protected]>
Adding glasbey colors according to a new naming pattern with aliases for Category, Category10, and Category20.
To Do:
Closes: #11