Fix links in docs when viewed in browser #1102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@adamjhawley Thanks for doing this. One of the discrepancies you identified was that we had an "Embedded" heading but it linked to a "Moving On" section. You have made them the same by using "Moving On" throughout, but I would rather it went the other way to be "Embedded" throughout. The other headings in the Pipeline section are technical and single word, and I think "Embedded" is more consistent. Would you be willing to switch back to using "Embedded"? If so, it will be ready to merge. |
Signed-off-by: adamjhawley <[email protected]>
Even though some Jupyter notebook readers will handle these links fine, they do not work when transformed to HTML and rendered in browsers. This patch fixes them so that they can be used in the browser too. Partially-fixes: holoviz#1101 Signed-off-by: adamjhawley <[email protected]>
Even though some Jupyter notebook readers will handle these links fine, they do not work when transformed to HTML and rendered in browsers. This patch fixes them so that they can be used in the browser too. Fixes: holoviz#1101 Signed-off-by: adamjhawley <[email protected]>
Even though some Jupyter notebook readers will handle these links fine, they do not work when transformed to HTML and rendered in browsers. This patch fixes them so that they can be used in the browser too. Signed-off-by: adamjhawley <[email protected]>
adamjhawley
force-pushed
the
pull-docs-links
branch
from
34f6725
to
19aab4a
Compare
|
Thanks for your feedback @ianthomas23. I've amended the relevant commit. You mentioned "Embedded" but the original link was to "Embedding" so I opted for the latter. Happy to change to "Embedded" if you would prefer though. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1101 - broken links in documentation when viewed from a browser.
Initial commits: