Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better handle returned dask npartitions in tests #1107

Merged
merged 1 commit into from
Aug 9, 2022
Merged

Better handle returned dask npartitions in tests #1107

merged 1 commit into from
Aug 9, 2022

Conversation

ianthomas23
Copy link
Member

This is a workaround for issue #1106.

When we request npartitions=2 when converting a pandas to a dask DataFrame, we may receive 1 or 2 partitions depending on the version of dask. Line and area tests using axis=0 have different results depending on the number of partitions as datashader does not cope with npartitions > 1 for these axis=0 situations.

The workaround here is to check the number of partitions in the returned dask.DataFrame to do an appropriate comparison test so that our CI passes regardless of dask version. Our functionality is no more broken than it was before, but users are more likely to be seeing inappropriate results with dask >= 2022.8.

@ianthomas23 ianthomas23 added the bug label Aug 8, 2022
@ianthomas23 ianthomas23 merged commit f0aa939 into holoviz:master Aug 9, 2022
@ianthomas23 ianthomas23 deleted the issue1106_dask_npartitions branch July 19, 2023 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant