Do not automatically trigger the creation of a spatialpandas spatial index #882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use it if it's there, but don't create it
|
Looks good. Feel free to merge once the PR build passes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Slight change in Datashader's use of
spatialpandasthat I made in order to match the legacy performance of https://examples.pyviz.org/osm/osm-1billion.html#osm-gallery-osm-1billion.With this change, Datashader will use the per-partition spatial index if one is present but it will not trigger the creation of a new spatial index. Datashader will still always use/create a spatialindex across all of the partitions in order to judge which partitions are needed.