Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Gallery #121

Merged
merged 36 commits into from
Apr 24, 2018
Merged

Add a Gallery #121

merged 36 commits into from
Apr 24, 2018

Conversation

philippjfr
Copy link
Member

@ceball I realize you're probably not done here, but I wanted to add a PR so we can discuss. I'll add some initial examples shortly.

@ceball
Copy link
Member

ceball commented Jan 14, 2018

Ha, I typed up the following but when I tried to submit got an error about such a PR already existing. I was very confused until I realized what had happened!

@ceball
Copy link
Member

ceball commented Jan 14, 2018

This is how I tried to open the PR:

@philippjfr, do you want to add specific, new "gallery" notebooks for the gallery? (That's what I've started to do here, copying holoviews' scheme, and a notebook from holoviews as a placeholder.)

Or should we generate a gallery from the existing notebooks?

Also, can/does any of this relate to 'topics' or 'showcase'? Datashader has topics (https://bokeh.github.io/datashader-docs/topics/index.html), while holoviews has (unused?) showcase.

@jbednar and/or @jlstevens might want to weigh in too (thinking about pyviz projects in general).

There may be an existing issue about this somewhere. Sorry if I missed that.

@ceball ceball changed the title Add a Gallery WIP: Add a Gallery Jan 14, 2018
@philippjfr
Copy link
Member Author

@philippjfr, do you want to add specific, new "gallery" notebooks for the gallery?

Yes, I've written 15 gallery examples so far and will add them shortly.

Also, can/does any of this relate to 'topics' or 'showcase'?

Currently I don't have any plans for topics or showcase notebooks in GeoViews so we can leave this for now. We should add a topics section to HoloViews soon though.

@philippjfr
Copy link
Member Author

philippjfr commented Jan 14, 2018

@ceball Is the extra nesting in the gallery examples required, i.e. can we get rid of the second notebooks directory in the path: notebooks/gallery/notebooks/matplotlib/area_chart.ipynb?

@philippjfr
Copy link
Member Author

philippjfr commented Jan 14, 2018

Just added my initial gallery examples, let me know if there's a good reason for the extra nesting and I should move them into notebooks/gallery/notebooks. I'll let you decide and remove the HoloViews examples then.

@ceball
Copy link
Member

ceball commented Jan 14, 2018

The extra nesting's just copied from holoviews, where there's gallery/notebooks and gallery/apps. Doesn't seem necessary to me, but maybe I'm missing something?

@ceball
Copy link
Member

ceball commented Jan 14, 2018

@philippjfr, do you happen to know why I might see this (on macos) while trying to generate gallery thumbnails for some notebooks:

/Users/cball/anaconda3/envs/ioamdocenv/lib/python3.6/site-packages/holoviews/plotting/mpl/__init__.py:30: FutureWarning: 'pandas.tseries.converter.register' has been moved and renamed to 'pandas.plotting.register_matplotlib_converters'. 
  converter.register()
Traceback (most recent call last):
  File "<stdin>", line 56, in <module>
NameError: name 'plot_opts' is not defined
brexit_referendum thumbnail export failed

If you have no idea, I'll investigate.

@philippjfr
Copy link
Member Author

Looks like a bug I didn't catch, will push a fix in a second.

@ceball
Copy link
Member

ceball commented Jan 14, 2018

(Note that I haven't tried to run the notebooks via the notebook server yet, so it could alternatively be something from the gallery generation.)

@philippjfr
Copy link
Member Author

The extra nesting's just copied from holoviews, where there's gallery/notebooks and gallery/apps. Doesn't seem necessary to me, but maybe I'm missing something?

Just checked and they're broken into apps and demos. That is actually somewhat useful to separate it into sections.

@philippjfr
Copy link
Member Author

philippjfr commented Jan 14, 2018

Know of any nice geographic plots to replicate? I've mostly been working my way through the cartopy gallery. I also still have to add attributions and cross-links between bokeh and matplotlib notebooks.

@ceball
Copy link
Member

ceball commented Jan 14, 2018

Just checked and they're broken into apps and demos. That is actually somewhat useful to separate it into sections.

Ok. It's configurable now. For now, I'd like to carry on with the structure you used here; we can change it later.

@ceball
Copy link
Member

ceball commented Jan 14, 2018

Pushes on this PR appear at https://ioam-docs.github.io/geoviews-master/gallery/index.html

@philippjfr
Copy link
Member Author

What's the easiest way to add jQuery? It doesn't seem to be loading causing a number of issues.

@philippjfr
Copy link
Member Author

Nevermind, works now.

@jbednar
Copy link
Member

jbednar commented Jan 15, 2018

Know of any nice geographic plots to replicate?

I don't have anything specific in mind, but anything with about 50 different plots overlaid onto the same map will help reassure people they can make the same incomprehensible map plots I saw everywhere in the AMS meeting this week. :-)

(Seriously, I think interactive GeoViews+Bokeh plots could really cut down on some of this need to cram everything into the same or adjacent plots, by using interactive features to reveal data as needed rather than having "cramming it in" be the only way for data to be available.)

@philippjfr
Copy link
Member Author

Thanks for your help @ceball. I'm going to go ahead and merge this for now. I'll probably follow up with tweaks in a new PR.

@philippjfr philippjfr merged commit df7be89 into master Apr 24, 2018
@@ -3,6 +3,7 @@ language: python

sudo: false

TODO: update when to upload to ioam-docs before merging
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something went wrong for you in a rebase and/or merge? This should be a comment (# TODO: ...).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bizarre, no idea how that could possibly happen. That said, master seem to have been building okay. Will fix it some time today.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Presumably manual error during merge? Anyway, I like the idea of travis having a TODO key, which you use to tell it what to do in the future. But evidently they haven't implemented that yet...

@philippjfr philippjfr deleted the gallery branch May 8, 2018 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants