Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added additional Esri tile sources #176

Merged
merged 3 commits into from
May 17, 2018
Merged

Added additional Esri tile sources #176

merged 3 commits into from
May 17, 2018

Conversation

jbednar
Copy link
Member

@jbednar jbednar commented May 16, 2018

There are several Esri tile sources that are useful in addition to those included, and this PR adds them with the attributions as listed on the ArcGIS websites:

This PR also fixes broken attributions caused by malformed tuples for cartodb and cartocdn. Finally, it renames ESRI to EsriImagery, to reflect that there are many Esri map servers, though the original name is preserved for compatibility with the 1.5 gv release.

@jbednar jbednar requested a review from philippjfr May 16, 2018 22:44
Copy link
Member

@philippjfr philippjfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great thanks!

@jbednar jbednar merged commit 584f3f3 into master May 17, 2018
@jbednar jbednar deleted the tiles branch May 17, 2018 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants