-
-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added fixes for longitude wrapping when projecting Image #260
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
031765a
Added fixes for longitude wrapping when projecting Image
philippjfr 9f12188
Fixed bug projecting QuadMesh
philippjfr eb2215f
Bumped version requirements
philippjfr 10193aa
Losened cartopy version requirement
philippjfr fefba72
Updated unit test
philippjfr 994d7fe
Downgraded holoviews for now
philippjfr 19b9c1f
Added custom call to gv.Feature
philippjfr 1d12637
Downgraded holoviews temporarily
philippjfr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,37 @@ | ||
import numpy as np | ||
import cartopy.crs as ccrs | ||
|
||
from geoviews.element import Image | ||
from geoviews.element.comparison import ComparisonTestCase | ||
from geoviews.operation import project | ||
|
||
|
||
class TestProjection(ComparisonTestCase): | ||
|
||
def test_image_latlon360_wrapping(self): | ||
xs = np.linspace(0, 360, 5) | ||
ys = np.linspace(-90, 90, 3) | ||
img = Image((xs, ys, xs[np.newaxis, :]*ys[:, np.newaxis])) | ||
proj = project(img, projection=ccrs.PlateCarree()) | ||
zs = proj.dimension_values('z', flat=False) | ||
self.assertEqual(zs, np.array([ | ||
[-24300., -0., -8100.], | ||
[ 0., 0., 0.], | ||
[ 0., 0., 0.], | ||
[ 0., 0., 0.], | ||
[ 24300., 0., 8100.] | ||
])) | ||
|
||
def test_image_project_latlon_to_mercator(self): | ||
xs = np.linspace(0, 360, 5) | ||
ys = np.linspace(-90, 90, 3) | ||
img = Image((xs, ys, xs[np.newaxis, :]*ys[:, np.newaxis])) | ||
proj = project(img) | ||
zs = proj.dimension_values('z', flat=False) | ||
self.assertEqual(zs, np.array([ | ||
[-24300., -0., -8100.], | ||
[-24300., -0., -8100.], | ||
[ 0., 0., 0.], | ||
[ 24300., 0., 8100.], | ||
[ 24300., 0., 8100.] | ||
])) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops! Copy-paste error?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably, yes.