Removed all references to holocube and deleted interface #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philippjfr
force-pushed
the
holocube_delete
branch
4 times, most recently
from
23fc0e3
to
7e39014
Compare
philippjfr
force-pushed
the
holocube_delete
branch
from
7e39014
to
7d47a5e
Compare
|
The PR you mention how now been merged. Is this one ready to merge too? |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR deletes all references to the holocube package and the HoloCube class, instead relying on HoloViews to provide the CubeInterface. This should be merged once holoviz/holoviews#624 has been merged in HoloViews.