Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accept lowercase xmin/ymin/xmax/ymax #542

Merged
merged 1 commit into from
Nov 18, 2021
Merged

Accept lowercase xmin/ymin/xmax/ymax #542

merged 1 commit into from
Nov 18, 2021

Conversation

ahuang11
Copy link
Collaborator

@ahuang11 ahuang11 commented Nov 18, 2021 •
edited
Loading

jbednar
jbednar approved these changes Nov 18, 2021
View reviewed changes
Copy link
Member

@jbednar jbednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, thanks. The test failures look like they have a common source, e.g. some change in xarray, but I don't know what's happening there.

@maximlt
Copy link
Member

maximlt commented Nov 18, 2021

They're mostly, if not entirely, due to changes in shapely 1.8.0. Will try to fix that in the next days.

@jbednar jbednar merged commit 59ccc79 into master Nov 18, 2021
@jbednar jbednar deleted the lowercase_extents branch November 18, 2021 19:46
@maximlt maximlt mentioned this pull request Dec 22, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbednar jbednar jbednar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ahuang11 @maximlt @jbednar