Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt to shapely 2.0 #570

Merged
merged 2 commits into from
May 19, 2022
Merged

Adapt to shapely 2.0 #570

merged 2 commits into from
May 19, 2022

Conversation

maximlt
Copy link
Member

@maximlt maximlt commented May 2, 2022

Warnings seen while running hvplot's notebooks. Continue the work started in #543. This warning was not seen as this code path doesn't seem to be run part of the CI.

@maximlt maximlt merged commit 45d754d into master May 19, 2022
@maximlt maximlt deleted the shapely_2_compat branch May 19, 2022 14:37
@hoxbro hoxbro mentioned this pull request Aug 28, 2022
@TheoMathurin
Copy link

Hi,

Does this solve this other Shapely-related deprecation warning, popping up when calling gv.operation.resample_geometry?

ShapelyDeprecationWarning: STRtree will be changed in 2.0.0 and will not be compatible with versions < 2. tree = STRtree(geoms)

@maximlt
Copy link
Member Author

maximlt commented Oct 10, 2022

Hmm I ran the test suite to list the warnings triggered by Shapely. resample_geometry isn't tested apparently so I missed this deprecation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants