Support variety of data inputs for wind barbs #662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbednar
changed the title
hoxbro
reviewed
Jul 10, 2023
There was a problem hiding this comment.
Do you think we should add an extra test where vdims is [hv.Dimension("u"), hv.Dimension("v")].
I don't know if this will give any problems but using hv.Dataset will flatten the array. I can see you already have flattened the result array because of this.
import numpy as np
import holoviews as hv
x = np.array([-1, 1])
X, Y = np.meshgrid(x, x)
U, V = 10 * X, 2 * Y
U
ds = hv.Dataset((X, Y, U, V), kdims=["x", "y"], vdims=["u", "v"])
ds.dimension_values("u")
|
I don't think the flattening matters. It'll still plot to the same coord point. |
hoxbro
approved these changes
Jul 10, 2023
There was a problem hiding this comment.
Let us keep this PR open to sync if more changes are added in holoviz/holoviews#5797.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on feedback from
holoviz/holoviews#5797