Skip to content

Commit

Permalink
Merge pull request #1231 from ioam/extension_banner_option
Browse files Browse the repository at this point in the history
Replaced extension logo parameter with banner toggle
  • Loading branch information
philippjfr committed Mar 29, 2017
2 parents 25fde35 + e255509 commit 5e6d0d2
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions holoviews/ipython/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,8 @@ class notebook_extension(param.ParameterizedFunction):

css = param.String(default='', doc="Optional CSS rule set to apply to the notebook.")

logo = param.Boolean(default=True, doc="Toggles display of HoloViews logo")
banner = param.Boolean(default=True, doc="""
Toggles display of HoloViews logo and loading message.""")

inline = param.Boolean(default=True, doc="""Whether to inline JS and CSS resources,
if disabled resources are loaded from CDN if one is available.""")
Expand Down Expand Up @@ -206,8 +207,8 @@ def __call__(self, *args, **params):
loaded = ', '.join(js_names[r] if r in js_names else r.capitalize()+'JS'
for r in resources)

load_hvjs(logo=p.logo, JS=('holoviews' in resources),
message = '%s successfully loaded in this cell.' % loaded)
message = '' if not p.banner else '%s successfully loaded in this cell.' % loaded
load_hvjs(logo=p.banner, JS=('holoviews' in resources), message = message)
for r in [r for r in resources if r != 'holoviews']:
Store.renderers[r].load_nb(inline=p.inline)

Expand Down

0 comments on commit 5e6d0d2

Please sign in to comment.