Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bokeh tool bar disappears when data type inside a DynamicMap changes #2784

Closed
basnijholt opened this issue Jun 8, 2018 · 8 comments
Closed

Comments

@basnijholt
Copy link
Contributor

bokeh

import holoviews as hv
hv.notebook_extension('bokeh')

def plot():
    while True:
        if path:
            yield hv.Overlay([hv.Path([])])
        else:
            yield hv.Overlay([hv.Scatter([])])

path = True
dm = hv.DynamicMap(plot(), streams=[hv.streams.Stream.define('Next')()])
dm

then run

path = False
dm.event() 

This currently blocks https://gitlab.kwant-project.org/qt/adaptive/merge_requests/72
Somewhat related #2494

@philippjfr
Copy link
Member

This is a bokeh issue to do with the way renderers are synced between frontend and backend and nothing on our end will fix it. The related bokeh issues are bokeh/bokeh#7497 and bokeh/bokeh#7590. This is precisely why I was worried about adding the ability to dynamically add new subplots, but iirc you persuaded me that we should go ahead and merge that despite this issue.

@basnijholt
Copy link
Contributor Author

basnijholt commented Jun 8, 2018

but iirc you persuaded me that we should go ahead and merge that despite this issue

That's true, I remember now! (and I still agree with my past self 😜)

@philippjfr
Copy link
Member

Anyway, filing an issue is still sensible to track the progress in bokeh.

@basnijholt
Copy link
Contributor Author

basnijholt commented Sep 17, 2018

It seems like bokeh/bokeh#8085 (PR) fixes bokeh/bokeh#7497 and bokeh/bokeh#7590 is already fixed 😄

This will unblock qt/adaptive!72.

@basnijholt
Copy link
Contributor Author

bokeh/bokeh#8085 is finally merged and it seems that it will be in bokeh 1.1.0.

@philippjfr
Copy link
Member

Yes, this will be fixed once we release hv 1.12.0 some time next week. The current release of holoviews will not support bokeh 1.1.0.

@philippjfr philippjfr added this to the v1.12.0 milestone Mar 5, 2019
@philippjfr
Copy link
Member

I think we can just merge this since it'll be fixed without any action on our part.

basnijholt added a commit to python-adaptive/adaptive that referenced this issue Mar 11, 2019
because HoloViews can now handle changing datatypes in DynamicMaps
see holoviz/holoviews#2784
basnijholt added a commit to python-adaptive/adaptive that referenced this issue Apr 18, 2019
because HoloViews can now handle changing datatypes in DynamicMaps
see holoviz/holoviews#2784
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants