Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RangeX stream event doesn't trigger the event after update to v1.15 #5381

Closed
ruoyu0088 opened this issue Aug 9, 2022 · 5 comments · Fixed by #5465
Closed

RangeX stream event doesn't trigger the event after update to v1.15 #5381

ruoyu0088 opened this issue Aug 9, 2022 · 5 comments · Fixed by #5465
Labels
type: bug Something isn't correct or isn't working
Milestone

Comments

@ruoyu0088
Copy link
Contributor

ruoyu0088 commented Aug 9, 2022

holoviews v1.15

Here is the example code, I create two DynamicMaps that share X axis and Y axis range, If I change the X axis range with PAN or ZOOM tools to one of the plots, both X axis range of the two plots are changed synchronized. The RangeX stream then trigger the callback functions to update the Curve's data. In holoviews 1.14.9, both of the two curves are changed, but after updated to v1.15, only the plot with mouse event are changed.

import numpy as np
import holoviews as hv
from holoviews.streams import RangeX
hv.extension('bokeh')

def cos(x_range):
    t = np.linspace(x_range[0], x_range[1], 500)
    return hv.Curve((t, np.cos(t)))

def sin(x_range):
    t = np.linspace(x_range[0], x_range[1], 500)
    return hv.Curve((t, np.sin(t)))    

(
    hv.DynamicMap(cos, streams=[RangeX(x_range=(1, 10))]) +
    hv.DynamicMap(sin, streams=[RangeX(x_range=(1, 10))])
).cols(1).opts(hv.opts.Curve(width=600))

Here is the screen shot after zoom out the first plot:

image

Here is the screen shot of v.1.14.9, both of the two Curves are updated:

image

further more, the response speed of 1.14.9 is better then 1.15.

@hoxbro hoxbro added the bug label Aug 9, 2022
@philippjfr philippjfr added this to the 1.15.1 milestone Aug 9, 2022
@hoxbro
Copy link
Member

hoxbro commented Aug 9, 2022

A git bisect shows that #5265 is the culprit.

(git commit: 9265a12dca74dd84b411d31771eb2ef7bbab6ee1)

@philippjfr
Copy link
Member

Yes, that is definitely the culprit. That I don't think we should simply roll that back. It will be more difficult to fix this properly but I think it's worth it.

@maximlt maximlt added type: bug Something isn't correct or isn't working and removed tag: bug labels Aug 25, 2022
@philippjfr
Copy link
Member

Could you report your current panel version? I can't reproduce with latest holoviews + panel.

@hoxbro
Copy link
Member

hoxbro commented Aug 29, 2022

I still see the problem here is my versions:

pn.__version__    '0.14.0a9+gbd32dd50-dirty'
hv.__version__    '1.15.0.post10+g29ccf905e'

Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: bug Something isn't correct or isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants