Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure rangesupdate event fires on all plots with linked axes #5465

Merged
merged 4 commits into from
Oct 4, 2022

Conversation

philippjfr
Copy link
Member

Fixes #5381

@philippjfr philippjfr added this to the 1.15.1 milestone Oct 2, 2022
@codecov-commenter
Copy link

codecov-commenter commented Oct 2, 2022

Codecov Report

Merging #5465 (d097a77) into master (e2f55d4) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #5465   +/-   ##
=======================================
  Coverage   88.12%   88.12%           
=======================================
  Files         301      301           
  Lines       62104    62108    +4     
=======================================
+ Hits        54730    54734    +4     
  Misses       7374     7374           
Impacted Files Coverage Δ
holoviews/plotting/bokeh/callbacks.py 62.99% <100.00%> (+0.19%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@philippjfr
Copy link
Member Author

Will push a fix later.

@jlstevens
Copy link
Contributor

Odd, there is the following error, but only on 3.9 ubuntu?!

    def test_poly_edit_callback(self):
        polys = Polygons([[(0, 0), (2, 2), (4, 0)]])
        poly_edit = PolyEdit(source=polys)
        plot = bokeh_server_renderer.get_plot(polys)
>       self.assertIsInstance(plot.callbacks[0], PolyEditCallback)
E       AssertionError: <holoviews.plotting.bokeh.callbacks.PolyDrawCallback object at 0x7efd2eb31340> is not an instance of <class 'holoviews.plotting.bokeh.callbacks.PolyEditCallback'>

@philippjfr
Copy link
Member Author

Nothing to do with this PR, has been a transient for over a year now.

@jlstevens
Copy link
Contributor

I was wondering if it was a transient but I never realized we had one that was an isinstance check failing. Very weird!

Anyway, merging.

@jlstevens jlstevens merged commit 3e5ea6c into master Oct 4, 2022
@jlstevens jlstevens deleted the rangesupdate_fix branch October 4, 2022 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RangeX stream event doesn't trigger the event after update to v1.15
3 participants