-
-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rounding of DynamicMap range causes bug #601
Comments
I am encountering this bug now. It took me a while to figure out it was not because I was doing something stupid. Any recommended workarounds? |
No I don't know of any workarounds, but this is a high priority issue and I will try to have it fixed asap. |
I imagine this will be an issue if you have something like |
@basnijholt Could you confirm the bug is fixed for you? |
Sorry, I didn't commit the nonworking code, so it's not easy for me to check. If you like I'll try to reproduce on Monday :) |
I'll close, please reraise the issue if needed. |
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Currently due to precision differences in Python vs. Javascript we round values to 10 decimal places. This ensures that the values will match between Python and Javascript, however rounding can result in rounding down or up, which can cause problems. When the upper limit of a dimension is rounded up for example, the rounded value will be outside the limit defined by the dimension range. When moving the slider to the maximum position it will therefore request a frame from Python which falls outside of its defined range and will raise an exception. We should ensure that the rounded values sent to JS are within the original range defined on the dimension.
The text was updated successfully, but these errors were encountered: