Added logging output support to unittests #1259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@philippjfr I want this to be a quick PR and I do think it is ready to review/merge once the tests go green. |
|
Looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows us to finally check param's logging output. We have often wanted to check the output of
param.warningbut haven't had the infrastructure to do so. This is important as we want to improve exceptions and warnings throughout HoloViews.This PR includes an example of how the new
LoggingComparisonTestCaseis used, involving a recent unit test where I wanted to check the param.warning output.I'll be using this new system in a number of new unit tests I am planning but I don't intend to go back and update all the existing tests right now as it would take some thought to figure out where logging output should be checked. That could be work for a future PR and could be something to do before HoloViews 2.0.