Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restored logo parameter and removed banner text #1291

Merged
merged 1 commit into from
Apr 14, 2017
Merged

Restored logo parameter and removed banner text #1291

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions holoviews/ipython/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,8 +117,7 @@ class notebook_extension(param.ParameterizedFunction):

css = param.String(default='', doc="Optional CSS rule set to apply to the notebook.")

banner = param.Boolean(default=True, doc="""
Toggles display of HoloViews logo and loading message.""")
logo = param.Boolean(default=True, doc="Toggles display of HoloViews logo")

inline = param.Boolean(default=True, doc="""Whether to inline JS and CSS resources,
if disabled resources are loaded from CDN if one is available.""")
Expand Down Expand Up @@ -229,8 +228,7 @@ def __call__(self, *args, **params):
loaded = ', '.join(js_names[r] if r in js_names else r.capitalize()+'JS'
for r in resources)

message = '' if not p.banner else '%s successfully loaded in this cell.' % loaded
load_hvjs(logo=p.banner, JS=('holoviews' in resources), message = message)
load_hvjs(logo=p.logo, JS=('holoviews' in resources), message='')



Expand Down