Fixed bokeh BarPlot implementation #1405
Conversation
philippjfr
added
tag: backend: bokeh
type: bug
|
I'm all in favor of simplifying the barplot implementations. Happy to merge if you think it is ready and the tests pass. |
|
The main worry is probably backwards compatibility... |
I've made sure that it still behaves as before for the simple case and for the stacking case. Any other combinations were simply wrong and buggy before (probably part of the reason you complained about it being unintuitive before). |
|
I've opened an issue to summarize my conclusions about BarPlots. |
|
Not sure there are any new unit tests to write. If you are done, I'm happy to merge as the tests are green. |
Bars are tested as part of the Bokeh_Elements tutorial so yes please merge. |
We've been discussing the Bars element quite a lot recently and that its behavior was confusing. Having had to use Bars extensively I now realize the reason for that is that the current implementation doesn't really make any sense and is completely inconsistent with what the matplotlib version does.
While we will deprecate this bokeh charts plot implementation in favor of our own very soon, I still think this is worth fixing for the time being. In future we have plans to allow grouping and stacking of Bars by overlaying them. However as we move away from a bokeh charts based interface the behavior it has now is probably reasonable for a transitional period while we solve issues surrounding categorical axes in the matplotlib backend and issues surrounding nested coordinate systems in bokeh. The matplotlib plot should still be simplified to disallow simultaneous grouping and stacking, resulting in a horrendously complicated plotting class.