Operation refactor in core #1421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlstevens
force-pushed
the
operation_refactor
branch
from
4ca38fe
to
616bab8
Compare
|
@philippjfr Tests are finally passing. Ready to review. If you want me to handle TreeOperation right away, just tell me what you recommend and I can add those changes to this PR. |
|
Let's get to that later once I've figured out whether there's something general there we can keep in HoloViews. Merging this now so you can continue with the Operations tutorial refactor. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements part of the suggestion in #1419, removing
MapOperationand mergingOperationandElementOperation.It doesn't do anything to
TreeOperationjust yet which results in the duplication of classmethods. I would like to see this PR merged before I continue reviewing the new operations tutorial.