-
-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add example notebooks for Elements #1476
Conversation
One thing I want to add later is to automatically parse all the other examples and then insert a final cell to each example notebooks which links to all the examples in which the element is used. |
Sounds like a plan! |
ec64bb3
to
95ef2be
Compare
Note that the |
@philippjfr I've now gone through and updated all the notebooks in the original commit as well as From now on, I'm happy to edit/review the element notebooks as you push them. Alternatively, I can start authoring some myself in which case we need to decide how to split the remaining elements between us. |
How about you do |
Sounds like a plan, I've got Path and Histogram drafts locally already. |
I've copied all the bokeh notebooks and I am working through them to update them. So far I've updated: Area, Bounds, Box, BoxWhisker, Contours and Curve. Issues
Notes:
|
Contours colormapping and ticks PRs now merged. |
9a7891e
to
8375e69
Compare
8375e69
to
bf9b395
Compare
This PR contains a ton of work we should probably merge sooner rather than later. I can file an issue about the things we discovered while running through all this. @philippjfr What do you think? |
Sounds good, let's make sure to squash merge this. |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
As one of the main tasks for the new documentation we want to split out the example notebooks. I started converting individual examples and in doing so found that many examples in the existing Element tutorials are either outdated or downright wrong so I started updating them. I got through a fair few of them and made bokeh specific additions. It probably would have been easier to start porting the existing materials and then adapting them once they are added and only then add backend specific additions for the different backend specific versions.
Given that I've already started updating them I'd suggest the following plan, that @jlstevens can help me with. I'd suggest you work through the Elements I've already added and add matplotlib versions for each, making improvements to both versions if you think they are necessary and replacing/removing bits that rely on bokeh features in the matplotlib version (e.g. hover tool -> show_values in the HeatMap example). In the meantime I'll work on bokeh and matplotlib versions of the outstanding elements, which are: