Allow aggregate to rasterize to target Image gridding #1513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philippjfr
force-pushed
the
aggregate_target
branch
from
437cb62
to
2945ff1
Compare
philippjfr
force-pushed
the
aggregate_target
branch
from
2945ff1
to
845d03a
Compare
|
This PR now also fixes an issue arising due to the difference of coordinate systems in datashader and holoviews. Datashader coordinates are aligned at the bottom, left edge of each bin, while holoviews coordinates are placed at the bin centers. I'm now appropriately offsetting the datashader coords and added some (optional) unit tests to check this. |
|
Looks good. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows the aggregate datashader operation to generate rasterize data onto the same grid as an existing Image. This is very useful when working with columnar and rasterized datasets and want to merge them into the same space, allowing simple arithmetic and more complex machine learning pipelines to be performed on the data.
Technically this is a complete regridding solution even for Images but hopefully we can decide what to do about a more efficient
gridtoolsbased implementation (which I already prototyped).