Bokeh SplinePlot handles multiple cubic splines #1529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlstevens
reviewed
Jun 12, 2017
| if len(vs) != 4: | ||
| skipped = len(vs) > 1 | ||
| continue | ||
| xs, ys = vs[:, 0], vs[:, 1] |
There was a problem hiding this comment.
Maybe zip the string keys and values and loop over them to append?
|
Looks good! Not sure what unit tests could be added and I made one comment to try to avoid all the lines using |
|
Simplified the SplinePlot implementation. We could expand on the Spline Element notebook with the hope that they will be tested eventually. |
|
Looks good! |
|
Looks good! I'll merge once the tests are green. |
|
Tests have passed. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bokeh bezier glyph supports cubic splines, by reading the matplotlib based spline codes we can easily split a set of cubic splines and draw them correctly with bokeh. This PR adds supports for drawing multiple cubic splines in this way. Splines of length 1 are simply ignored, while any other splines will raise warning. Briefly I thought I could handle quadratic and linear splines as well but that does not seem to be the case. Also adds support for instantiating and plotting empty splines with
hv.Spline(([], [])).Here's an example: