Updated style with new show_frame settings #1610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What about Scatter and Points? They share a plotting class so setting it on the class won't be sufficient to give Points a frame and Scatter none. |
I think that is the only one that needs to be set with the options system and not at the class level. I'll push that fix now. |
jlstevens
force-pushed
the
show_frame_style
branch
2 times, most recently
from
32b8100
to
78e2d65
Compare
|
@philippjfr Looks like the tests will go green. Ready for final review/merge. |
|
Looks good will merge shortly. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Talking to @philippjfr we decided that only raster types, path types and vectorfields should have frames.