Replace (...) with .opts() #1760
Conversation
* Complements holoviz#1759 * Execute `git grep -lE '\)\((style|plot|norm)=' -- examples | xargs perl -pi -e 's/\)\((style|plot|norm)=/).opts($1=/g'` * Spot check notebooks
|
@jordansamuels Your regex-fu is certainly better than mine! I have now merged #1759 so you could rebase this PR off latest master? I can then try out this branch for some final checks. Alternatively, I can do the rebase if you give me the go-ahead because you have finished with your current set of changes. |
|
I found a few more, will update soon |
* __call__ to .opts() mods * __call__ to .opts() mods * __call__ to .opts() mods
* Manually search `git grep ')(' -- examples | grep -vE '.{255}'
* Fix cases by hand
`
|
I picked up 1759 in this, so I'm not sure it'll go okay. If not, I can make a separate PR. I think this is because I pushed the branch then rebased rather than merged to update fork. |
|
Actually I'm going to close this and make a new one. Cleaner and doesn't pollute the history. |
|
Cleaner version is #1763. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
git grep -lE '\)\((style|plot|norm)=' -- examples | xargs perl -pi -e 's/\)\((style|plot|norm)=/).opts($1=/g'