-
-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed scrubber bug and add support for discrete DynamicMap scrubber #1832
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
c001c2f
Allow scrubber widget for discrete DynamicMap
philippjfr 51147e9
Fixed and simplified scrubber widget
philippjfr ed799b6
Simplified plot len implementation
philippjfr 09f243d
Handle DynamicMap key expansion
philippjfr 5fc5e58
Ensure .map handles Dimension value validation errors
philippjfr 392a716
Fixed scrubber reserve animation error
philippjfr b58db6c
Fix for empty kdims
philippjfr 4c1f178
Added docstring and comment
philippjfr ee5fe62
Added unit tests for unique_dimkeys on discrete DynamicMap
philippjfr 8be0d5b
Reverted map fix and ensure DynamicMap keys are validated
philippjfr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -301,15 +301,16 @@ def get_widget(self_or_cls, plot, widget_type, **kwargs): | |
if not isinstance(plot, Plot): | ||
plot = self_or_cls.get_plot(plot) | ||
dynamic = plot.dynamic | ||
# Whether dimensions define discrete space | ||
discrete = all(d.values for d in plot.dimensions) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This seems to be the basic condition that determines when scrubber can be used (with |
||
if widget_type == 'auto': | ||
isuniform = plot.uniform | ||
if not isuniform: | ||
widget_type = 'scrubber' | ||
else: | ||
widget_type = 'widgets' | ||
elif dynamic: widget_type = 'widgets' | ||
elif widget_type == 'scrubber' and dynamic: | ||
raise ValueError('DynamicMap do not support scrubber widget') | ||
elif dynamic and not discrete: | ||
widget_type = 'widgets' | ||
|
||
if widget_type in [None, 'auto']: | ||
holomap_formats = self_or_cls.mode_formats['holomap'][self_or_cls.mode] | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we do this? Is this more useful than taking the set of keys then sorting them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There used to be at least, not sure its the case anymore though. Might leave a note to simplify this, but it's
used in a few places.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually I'll open an issue because this is related to sorting issues.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Opened the issue here: #1835