Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.8.4 hotfix release #1884

Merged
merged 4 commits into from
Sep 13, 2017
Merged

v1.8.4 hotfix release #1884

merged 4 commits into from
Sep 13, 2017

Conversation

jlstevens
Copy link
Contributor

This PR squashes the cherry picked commits on the release_1.8.4 branch (a temporary branch that will be deleted) in order to make a 1.8.4 hotfix release.

@jlstevens
Copy link
Contributor Author

jlstevens commented Sep 13, 2017

As this PR represents a new workflow for making hotfix release, I think it is worth summarizing the process:

  1. Each hotfix release branches should be branched off the previous one (e.g 1.8.4 is branched off 1.8.3)
  2. The bug fixes are cherry picked onto a temporary hotfix branch (e.g release_1.8.4)
  3. Once we are happy with that, we can make a single diff between the head of that branch and the previous hotfix release tag to get a single diff file. In this case I used git diff v1.8.3.
  4. That diff can be applied on a second branch, also off the previous hotfix. In this case this is the hotfix_1.8.4 branch used in this PR. The goal is to have a single commit with all the bug fixes with an annotated tag (here v1.8.4).
  5. The release can be made off that commit, then this PR can be merged into master with an appropriate merge commit (NOTE: DO NOT SQUASH MERGE!) and the temporary branch can be deleted.

@jlstevens
Copy link
Contributor Author

Tests are passing. Merging.

@jlstevens jlstevens merged commit c4dadfc into master Sep 13, 2017
@philippjfr philippjfr deleted the hotfix_1.8.4 branch September 28, 2017 20:11
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants