Bumped Travis testing dependencies to latest versions #2329
Conversation
philippjfr
force-pushed
the
travis_mpl_master
branch
from
58606ad
to
0f2f5f2
Compare
philippjfr
force-pushed
the
travis_mpl_master
branch
from
0f2f5f2
to
e0585ee
Compare
philippjfr
force-pushed
the
travis_mpl_master
branch
from
bef62ab
to
8256da5
Compare
|
Hopefully this works well. Just to be safe, we should make an explicit backup of the testing data before merging this PR. It will take a little while before we have a feel about the transients being better or worse so it is worth making sure we have the old testing data in case we have to revert in the worst case scenario. |
philippjfr
force-pushed
the
travis_mpl_master
branch
2 times, most recently
from
7a52d36
to
067a1b4
Compare
|
Looking quite hopeful that this resolves our transient issues. I restarted builds once so that's now 8 runs without a transient failure. Now that I've updated matplotlib it's time to start doing the same with pandas, dask, datashader and bokeh. |
|
I'd also like to switch from listing the travis dependencies in the .travis.yaml to using the environment.yml, with strict version requirements which will be guaranteed to work for testing and doc building. |
|
Uncovered a few bugs as part of this update. I expect one unit test to fail on this build, which I'll resolve in the morning. Once this is merged (along with the table PR) I think we're good to go for 1.9.4. |
philippjfr
force-pushed
the
travis_mpl_master
branch
from
070ccf3
to
c504264
Compare
philippjfr
force-pushed
the
travis_mpl_master
branch
6 times, most recently
from
3c89e27
to
7e9c3df
Compare
philippjfr
force-pushed
the
travis_mpl_master
branch
2 times, most recently
from
4cf953f
to
1eb2961
Compare
philippjfr
force-pushed
the
travis_mpl_master
branch
3 times, most recently
from
1ff18a6
to
e93c809
Compare
philippjfr
force-pushed
the
travis_mpl_master
branch
from
e93c809
to
c21e3f2
Compare
philippjfr
changed the title
|
Ready to merge now. I'll be restoring the disabled test in this PR #2338. After a lot of test runs I can confidently say that transients are reduced but unfortunately not eliminated. |
| @@ -73,12 +73,12 @@ def test_get_size_single_plot(self): | |||
| def test_get_size_row_plot(self): | |||
| plot = self.renderer.get_plot(self.image1+self.image2) | |||
| w, h = self.renderer.get_size(plot) | |||
| self.assertEqual((w, h), (576, 258)) | |||
| self.assertEqual((w, h), (576, 255)) | |||
There was a problem hiding this comment.
At least the changes here are small...
|
Looks good. I'm a little surprised at the changes in the size tests but at least the changes are small. As you said, this is long overdue so I am happy to merge now. |
Bumps the matplotlib version on Travis to 2.1.2 (i.e. latest). This is long overdue and hopefully will finally make the transient test failures disappear. Will require rebuilding test data of course.