Various unicode fixes for dimensions, Tables and widgets #352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -3,6 +3,8 @@ | |||
| axis or map dimension. Also supplies the Dimensioned abstract | |||
| baseclass for classes that accept Dimension values. | |||
| """ | |||
| from __future__ import unicode_literals | |||
|
|
|||
There was a problem hiding this comment.
Do you think we might need this anywhere else in HoloViews?
There was a problem hiding this comment.
Probably not a bad idea to add some of the __future__ imports everywhere including division, print_function and this one.
|
Looks fine. I wish there were a good way to know when |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses various unicode issues in Dimensions, Tables and Widgets. Opened to address #350 but fixes more wide-ranging issues.
Not yet ready for merge.