Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add spatialpandas interface and polygon rasterization #4120

Merged
merged 59 commits into from
Dec 18, 2019
Merged

Conversation

philippjfr
Copy link
Member

@philippjfr philippjfr commented Dec 6, 2019

  • Add spatialpandas interface
  • Add canonical conversion for all geometry data formats
  • Add support for rasterizing geometries
  • Add docs
  • Add tests

@philippjfr
Copy link
Member Author

Handling geometries consistently turned out to be a pretty hard problem taking me most of last week and most of today. Some of the features here:

  • .iloc will now work consistently throughout (meaning that Selection1D will work nicely)
  • .groupby is now handled consistently throughout
  • .sort is now implemented allowing us to sort by any dimension other than a geometry dimension
  • .values can now be used consistently to access both the geometry and value arrays (previously you had to split to access them)
  • Polygon and Ring geometries now always return closed rings from .values
  • All geometry interfaces can now be converted between one another meaning that they will even roundtrip nicely
  • Behavior for the native dictionary format is now well defined for different geometry types
  • Shared testing infrastructure for all geometry interfaces including MultiInterface (and all its subtypes), SpatialPandasInterface, GeoPandasInterface (in geoviews)

@philippjfr
Copy link
Member Author

Some of the Path plotting code looks pretty terrible now but it should all become much cleaner once I pick up #3986 again.

@philippjfr
Copy link
Member Author

This is ready to review.

@philippjfr
Copy link
Member Author

Thanks for the initial review @jlstevens, I've now made sure that only actual geometry interfaces are supported by Path types and reverted the API change on .split.

@jlstevens
Copy link
Contributor

@philippjfr Other than some comments above (most of which you have addressed already), I am happy to merge this PR now.

@jlstevens
Copy link
Contributor

Looks good. Thanks!

Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants