Delete toolbar by default before exporting the image #4422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philippjfr
reviewed
May 14, 2020
holoviews/util/__init__.py
Outdated
| @@ -782,6 +782,8 @@ def save(obj, filename, fmt='auto', backend=None, resources='cdn', **kwargs): | |||
| Additional keyword arguments passed to the renderer, | |||
| e.g. fps for animations | |||
| """ | |||
| if toolbar is None: | |||
There was a problem hiding this comment.
Suggested change
| if toolbar is None: | |
| if (backend == 'bokeh' or (backend is None and Store.current_backend == 'bokeh')) and toolbar is None: |
philippjfr
reviewed
May 14, 2020
holoviews/util/__init__.py
Outdated
| @@ -782,6 +782,8 @@ def save(obj, filename, fmt='auto', backend=None, resources='cdn', **kwargs): | |||
| Additional keyword arguments passed to the renderer, | |||
| e.g. fps for animations | |||
| """ | |||
| if toolbar is None: | |||
| obj.options(toolbar=None) | |||
There was a problem hiding this comment.
Suggested change
| obj.options(toolbar=None) | |
| obj = obj.opts(toolbar=None, backend='bokeh', clone=True) |
philippjfr
reviewed
May 14, 2020
holoviews/util/__init__.py
Outdated
| @@ -828,6 +830,8 @@ def render(obj, backend=None, **kwargs): | |||
| The rendered representation of the HoloViews object, e.g. | |||
| if backend='matplotlib' a matplotlib Figure or FuncAnimation | |||
| """ | |||
| if toolbar is None: | |||
There was a problem hiding this comment.
Suggested change
| if toolbar is None: | |
| if (backend == 'bokeh' or (backend is None and Store.current_backend == 'bokeh')) and toolbar is None: |
philippjfr
reviewed
May 14, 2020
holoviews/util/__init__.py
Outdated
| @@ -828,6 +830,8 @@ def render(obj, backend=None, **kwargs): | |||
| The rendered representation of the HoloViews object, e.g. | |||
| if backend='matplotlib' a matplotlib Figure or FuncAnimation | |||
| """ | |||
| if toolbar is None: | |||
| obj.options(toolbar=None) | |||
There was a problem hiding this comment.
Suggested change
| obj.options(toolbar=None) | |
| obj = obj.opts(toolbar=None, backend='bokeh', clone=True) |
|
Thanks @alexbraditsas! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refers to issue #3751
I created a new branch so that the review of the pr is easier, sorry for the other pr! Every comment or guideline in order to make the pr successful is more than welcome. Thanks in advance!