Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

copy index values to host for iteration #4646

Merged
merged 1 commit into from
Oct 23, 2020

Conversation

bryevdv
Copy link
Member

@bryevdv bryevdv commented Oct 13, 2020

cc @philippjfr @jlstevens

This PR adds some missing .values_host calls necessary on cudf indices before iteration. It fixes the following broken tests:

FAILED holoviews/tests/core/data/testcudfinterface.py::cuDFInterfaceTests::test_dataset_1D_reduce_hm - AttributeError: 'StringIndex' object has no attribute 'value_host'
FAILED holoviews/tests/core/data/testcudfinterface.py::cuDFInterfaceTests::test_dataset_1D_reduce_hm_alias - AttributeError: 'StringIndex' object has no attribute 'value_host'
FAILED holoviews/tests/core/data/testcudfinterface.py::cuDFInterfaceTests::test_dataset_1D_reduce_ht - AttributeError: 'StringIndex' object has no attribute 'value_host'
FAILED holoviews/tests/core/data/testcudfinterface.py::cuDFInterfaceTests::test_dataset_2D_reduce_hm - AttributeError: 'StringIndex' object has no attribute 'value_host'
FAILED holoviews/tests/core/data/testcudfinterface.py::cuDFInterfaceTests::test_dataset_2D_reduce_ht - AttributeError: 'StringIndex' object has no attribute 'value_host'

@bryevdv
Copy link
Member Author

bryevdv commented Oct 13, 2020

This still leaves the following broken cudf tests, most (all?) of which seem to relate to current lack of string support in cudf:

FAILED holoviews/tests/core/data/testcudfinterface.py::cuDFInterfaceTests::test_dataset_expanded_dimvals_ht - TypeError: unsupported operand type(s) for -: 'str' and 'str'
FAILED holoviews/tests/core/data/testcudfinterface.py::cuDFInterfaceTests::test_dataset_groupby - NotImplementedError: String Arrays is not yet implemented in cudf
FAILED holoviews/tests/core/data/testcudfinterface.py::cuDFInterfaceTests::test_dataset_groupby_alias - NotImplementedError: String Arrays is not yet implemented in cudf
FAILED holoviews/tests/core/data/testcudfinterface.py::cuDFInterfaceTests::test_dataset_groupby_dynamic - NotImplementedError: String Arrays is not yet implemented in cudf
FAILED holoviews/tests/core/data/testcudfinterface.py::cuDFInterfaceTests::test_dataset_groupby_dynamic_alias - NotImplementedError: String Arrays is not yet implemented in cudf
FAILED holoviews/tests/core/data/testcudfinterface.py::cuDFInterfaceTests::test_dataset_index_item_table - NotImplementedError: String Arrays is not yet implemented in cudf
FAILED holoviews/tests/core/data/testcudfinterface.py::cuDFInterfaceTests::test_dataset_index_row_age - NotImplementedError: String Arrays is not yet implemented in cudf
FAILED holoviews/tests/core/data/testcudfinterface.py::cuDFInterfaceTests::test_dataset_index_row_gender_female - NotImplementedError: String Arrays is not yet implemented in cudf
FAILED holoviews/tests/core/data/testcudfinterface.py::cuDFInterfaceTests::test_dataset_index_rows_gender_male - NotImplementedError: String Arrays is not yet implemented in cudf
FAILED holoviews/tests/core/data/testcudfinterface.py::cuDFInterfaceTests::test_dataset_index_value1 - NotImplementedError: String Arrays is not yet implemented in cudf
FAILED holoviews/tests/core/data/testcudfinterface.py::cuDFInterfaceTests::test_dataset_index_value2 - NotImplementedError: String Arrays is not yet implemented in cudf
FAILED holoviews/tests/core/data/testcudfinterface.py::cuDFInterfaceTests::test_dataset_sample_hm - holoviews.core.data.interface.DataError: Following columns specified as dimensions...
FAILED holoviews/tests/core/data/testcudfinterface.py::cuDFInterfaceTests::test_dataset_sample_hm_alias - holoviews.core.data.interface.DataError: Following columns specified as dime...
FAILED holoviews/tests/core/data/testcudfinterface.py::cuDFInterfaceTests::test_dataset_sample_ht - holoviews.core.data.interface.DataError: Following columns specified as dimensions...
FAILED holoviews/tests/core/data/testcudfinterface.py::cuDFInterfaceTests::test_dataset_select_rows_gender_male - NotImplementedError: String Arrays is not yet implemented in cudf
FAILED holoviews/tests/core/data/testcudfinterface.py::cuDFInterfaceTests::test_dataset_select_rows_gender_male_alias - NotImplementedError: String Arrays is not yet implemented in cudf
FAILED holoviews/tests/core/data/testcudfinterface.py::cuDFInterfaceTests::test_dataset_value_dim_index - NotImplementedError: String Arrays is not yet implemented in cudf
FAILED holoviews/tests/core/data/testcudfinterface.py::cuDFInterfaceTests::test_dataset_value_dim_scalar_index - NotImplementedError: String Arrays is not yet implemented in cudf

I'm not sure how you might like to handle this since it seems most or all of these tests are inherited from a test base class, so I am not sure the simplest way to disable them.

@bryevdv
Copy link
Member Author

bryevdv commented Oct 13, 2020

There are a few failing tests above with:

FAILED holoviews/tests/core/data/testcudfinterface.py::cuDFInterfaceTests::test_dataset_sample_hm - holoviews.core.data.interface.DataError: Following columns specified as dimensions...

And I am not sure those are string-related. Might be actual failures, but someone more knowledgeable than me will have to comment.

@bryevdv
Copy link
Member Author

bryevdv commented Oct 13, 2020

@philippjfr @jlstevens the test failures appear unrelated?

@philippjfr
Copy link
Member

Yeah, seeing those on another PR as well. Will check out this PR this evening on my GPU machine.

@philippjfr
Copy link
Member

Merging and will do a round of testing on my GPU machine in a minute.

@philippjfr philippjfr merged commit 5aaa706 into holoviz:master Oct 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants