Fix bug matching elements to subplots in DynamicMap #4649
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a longstanding bug in Overlay plots driven by a DynamicMap. The problem was that the code tried to assign subplots to elements that matched their spec, however each subplot would do this greedily so if a better match comes along later in the iteration then the plot would already have been assigned. This PR checks whether an exact match does exist and if it does it uses that instead.