Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix datashader instability by disabling plot padding for Plotly RGB elements. #4705

Merged
merged 2 commits into from
Nov 26, 2020

Conversation

jonmmease
Copy link
Collaborator

The introduction of plot padding last release broke the default behavior of using datashade with the plotly backend in the notebook. It resulted in the plot continually zooming out and crashing the kernel.

This simple (and I think appropriate) fix is to disable padding, by default, for the RGB elements with the plotly backend. Even apart from datashader, I think zero padding is a better default for RGB images as it's a bit awkward for there to be an empty border around them.

This fixes a datashader instability
@jbednar
Copy link
Member

jbednar commented Nov 26, 2020

Looks to me like this was just an oversight, because the Matplotlib and Bokeh backends already don't have padding for RGB or Image or Raster elements. I assume the same change should be made to Image and Raster?

@jonmmease
Copy link
Collaborator Author

Thanks, that makes sense. Done in 67fcb26

@jonmmease jonmmease merged commit 9d164d8 into master Nov 26, 2020
@jonmmease jonmmease deleted the plotly_rgb_padding branch November 26, 2020 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants