Updated the Responding to Events guide with streams dictionary examples #4822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philippjfr
reviewed
Feb 9, 2021
philippjfr
reviewed
Feb 9, 2021
jbednar
reviewed
Feb 9, 2021
There was a problem hiding this comment.
Looks good! The bank account seems fine, but since HoloViews is a plotting library you might consider making it have a graphical representation to display in the examples, either by making a Div that displays the underlying parameter values or by making them be parameters controlling some geometric figure (e.g. a small parameterized drawing made up of polygon or ellipse segments). As you wish!
Co-authored-by: James A. Bednar <[email protected]>
|
@philippjfr @jbednar I'm now happy with this PR having applies the suggested edits. Ready to merge? |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still WIP but I would appreciate if @jbednar @philippjfr can help me think of something more interesting than a bank account example (meant to be showing how a parameterized class can capture domain knowledge!)