Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed missing handling of nodata for count aggregator with column #4951

Merged
merged 5 commits into from
May 27, 2021

Conversation

jlstevens
Copy link
Contributor

The count_cat aggregators were handled but count wasn't. Simple fix that shouldn't need much discussion once a corresponding unit test is added.

Copy link
Member

@jbednar jbednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jlstevens
Copy link
Contributor Author

The test failure for 3.6 ubuntu seems unrelated to this PR. I tried restarting the tests but the same failure reappeared:

self = <holoviews.plotting.bokeh.callbacks.PointDrawCallback object at 0x7f197416c908>
plot_id = None

    def initialize(self, plot_id=None):
        plot = self.plot
        stream = self.streams[0]
>       cds = plot.handles['source']
E       KeyError: 'source'

@philippjfr Any idea what this failure is about? Is it simply a transient that happened twice in a row?

At any rate, happy to see this PR merged now.

Co-authored-by: Philipp Rudiger <[email protected]>
@philippjfr philippjfr added this to the v2.0 milestone May 27, 2021
@philippjfr philippjfr merged commit e02402b into master May 27, 2021
@philippjfr philippjfr deleted the count_cat_nodata_fix branch April 25, 2022 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants