Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core.data.interface): check if data.interface is a class #5050

Merged
merged 1 commit into from
Jul 30, 2021

Conversation

geronimos
Copy link
Contributor

check if data.interface is a class before calling issubclass()

Fixes holoviz/hvplot#645

Copy link
Member

@jbednar jbednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks perfect!

@philippjfr philippjfr merged commit 7dadbcb into holoviz:master Jul 30, 2021
@philippjfr
Copy link
Member

Thanks @geronimos!

philippjfr pushed a commit that referenced this pull request Aug 23, 2021
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

df.interactive() fails on a pandas DataFrame that has 'interface' in df.columns
3 participants