Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unhandled numpy.round overflow return value in core/util.py:bound_range(...) #5095

Merged
merged 3 commits into from
Nov 16, 2021
Merged

Fix unhandled numpy.round overflow return value in core/util.py:bound_range(...) #5095

merged 3 commits into from
Nov 16, 2021

Conversation

w31t1
Copy link
Contributor

@w31t1 w31t1 commented Oct 4, 2021

For the detailed analysis, I created an issue: #5094

Suggested changes

  1. Check additional for infinity:
        with warnings.catch_warnings():
            warnings.filterwarnings('ignore', r'invalid value encountered in double_scalars')
            full_precision_density = compute_density(low, high, len(vals)-1)
            density = round(full_precision_density, sys.float_info.dig)
        if density == 0 or density == np.inf:
            density = full_precision_density
  1. Disable Overflow FloatingPointErrors for the round call:
        with warnings.catch_warnings():
            warnings.filterwarnings('ignore', r'invalid value encountered in double_scalars')
            full_precision_density = compute_density(low, high, len(vals)-1)
            error = np.seterr(over="ignore")
            density = round(full_precision_density, sys.float_info.dig)
            np.seterr(**error)
        if density == 0:
            density = full_precision_density

Core/Util: Fix unhandled np.round overflow return
1520cee 
The function numpy.round return for the input
np.float64(2.6558061446181644e+295) the output
numpy.inf. This should lead to
density = full_precision_density.
Core/Util: Supress numpy.round overflow error
4a576b9 
The function numpy.round produces for the input
numpy.float64(2.6558061446181644e+295) an
FloatingPointError with the message
"overflow encountered in multiply". This error
should be suppressed because its an internal
computation by holoview.
@jlstevens
Copy link
Contributor

Sorry for not getting back to you sooner!

The fix looks like it would handle overflow safely and I am happy to merge once the tests pass. I think you'll need to rebase this PR to get the fixed tests running again.

@philippjfr philippjfr merged commit 403c1aa into holoviz:master Nov 16, 2021
philippjfr added a commit that referenced this pull request Nov 16, 2021
@w31t1 @philippjfr
Fix unhandled numpy.round overflow return value in core/util.py:bound…
1d9f19f 
…_range(...) (#5095)

* Core/Util: Fix unhandled np.round overflow return

The function numpy.round return for the input
np.float64(2.6558061446181644e+295) the output
numpy.inf. This should lead to
density = full_precision_density.

* Core/Util: Supress numpy.round overflow error

The function numpy.round produces for the input
numpy.float64(2.6558061446181644e+295) an
FloatingPointError with the message
"overflow encountered in multiply". This error
should be suppressed because its an internal
computation by holoview.

* Use context manager

Co-authored-by: [email protected] <[email protected]>
Co-authored-by: Philipp Rudiger <[email protected]>
maximlt added a commit that referenced this pull request Dec 16, 2021
@philippjfr @jbednar
@w31t1 @jenssss @douglas-raillard-arm @maximlt @martinfleis @hoxbro
Hotfix 1.14.7 (#5134)
27da6a3 
* Fix Violin matplotlib rendering with non-finite values (#5135)

* Handle the empty string as a group name (#5131)

* Fix unhandled numpy.round overflow return value in core/util.py:bound_range(...) (#5095)

* Core/Util: Fix unhandled np.round overflow return

The function numpy.round return for the input
np.float64(2.6558061446181644e+295) the output
numpy.inf. This should lead to
density = full_precision_density.

* Core/Util: Supress numpy.round overflow error

The function numpy.round produces for the input
numpy.float64(2.6558061446181644e+295) an
FloatingPointError with the message
"overflow encountered in multiply". This error
should be suppressed because its an internal
computation by holoview.

* Use context manager

Co-authored-by: [email protected] <[email protected]>
Co-authored-by: Philipp Rudiger <[email protected]>

* Update Plotting_with_Matplotlib.ipynb (#4983)

Ordering of the fig_bounds tuple in the documentation was different from that in e.g. https://github.com/holoviz/holoviews/blob/40977c515dd9837019aaa0e5708773e78809fbe1/holoviews/plotting/mpl/plot.py#L69

* Notimplemented binop (#5073)

* layout: Fix __add__ and __radd__ implementation

* Add layout.Layoutable as a mirror of overlay.Overlayable
* Remove a good deal of duplicated code
* Remove broken calls to super().__radd__ where the super class does not
  implement __radd__
* Return NotImplemented when Layout([x,y]) raises NotImplementedError.
  This allows correct interoperability with external classes that could
  themselves define __radd__ as stated by:
  https://docs.python.org/3/library/constants.html#NotImplemented

Fixes #3577

* overlay: deduplicate and fix __mul__

* Return NotImplemented when appropriate
* Deduplicate code between 2 non-trivial and almost identical
  implementations of __mul__
* Fix non-inheritance-friendly type checking with a local import to
  avoid cyclic dependency

Fixes #3577

* Fix matplotlib colorbar labeling for dim expressions (#5137)

* Ensure FreehandDraw renders when styles set (#5139)

* Fix datetime clipping on RangeXY stream (#5138)

* Fix Bars legend error when overlaid with annotation (#5142)

* Do not raise deprecated .opts warning for empty groups (#5144)

* Fix plotly Bar plots containing nans (#5143)

* Fix plotly Bar plots containing nans

* Update tests

* Preserve cols when overlaying on layout (#5141)

* Do not merge partially overlapping Stream callbacks (#5133)

* Do not merge partially overlapping Stream callbacks

* Add tests

* Remove print

* Add bounds to the cache_size Parameter (#5105)

* Fix broken link in Gridded user guide (#5098)

* Pin freetype on Windows due to matplotlib error (#5109)

* Fixed typo

* import bokeh's version from an internal util module (#5103)

* Add current_key property to DynamicMap (#5106)

* Validate dimensionality of xarray interface data (#5140)

* Support xyzservices.TileProvider as hv.Tiles input (#5062)

* implementation

* docstring, plotly test

* add bokeh tests

* CI: Fix before release (#5151)

* delay projection comparison to optimize geoviews (#5152)

* Test suite maintenance (#5157)

Fixed or suppressed warnings issued while running the tests

* fix cherry-pick and compatibility with holoviews 1.14

* fix linting

* Handle unsigned integer dtype in datashader aggregate operation (#5149)

* Fix docs CI build (#5088)

* Remove conda-forge from the build channels, post-install awscli and pin jupyter_client

* remove pytest usage

* add missing comma and fix test

* CI: improvements to the docs build (#5161)

* Fix for Contours consistent of empty and nonempty paths (#5162)

* Switch to the PyData sphinx theme (#5163)

* use pydata sphinx theme to build the site

* add pooch to the docs dependencies

* Add release notes for 1.14.6 and 1.14.7 (#5160)

* attempt to fix pip build

* micro fixes to the release notes

Co-authored-by: James A. Bednar <[email protected]>
Co-authored-by: w31t1 <[email protected]>
Co-authored-by: [email protected] <[email protected]>
Co-authored-by: jenssss <[email protected]>
Co-authored-by: Douglas Raillard <[email protected]>
Co-authored-by: Maxime Liquet <[email protected]>
Co-authored-by: James A. Bednar <[email protected]>
Co-authored-by: Martin Fleischmann <[email protected]>
Co-authored-by: maximlt <[email protected]>
Co-authored-by: Simon Høxbro Hansen <[email protected]>
@github-actions GitHub Actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@w31t1 @jlstevens @philippjfr