Handle recent versions of Ibis #5204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlstevens
reviewed
Feb 7, 2022
| from ibis.client import find_backends, validate_backends | ||
| (backend,) = validate_backends(list(find_backends(data))) | ||
| except Exception: | ||
| backend = data._find_backend() |
There was a problem hiding this comment.
That wasn't so bad after all!
|
Tests are going green. Merging. |
jlstevens
added a commit
that referenced
this pull request
Feb 7, 2022
|
Thanks @philippjfr ! The tests that ran in this PR were using ibis < 2 so not really testing the change, I'm hopeful I can get the CI to actually test ibis >= 2. |
That would be great! |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for ibis > 2.0