Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug in bokeh hover tool for unsanitized dimensions #524

Merged
merged 1 commit into from
Feb 28, 2016

Conversation

philippjfr
Copy link
Member

The bokeh hover tool currently breaks if a dimension contains a space or other special character, the PR adds a small method to generate the hover data correctly.

@philippjfr philippjfr added type: bug Something isn't correct or isn't working tag: backend: bokeh labels Feb 27, 2016
@philippjfr philippjfr added this to the 1.4.4 milestone Feb 27, 2016
@jlstevens
Copy link
Contributor

Also looks like the new method removes redundancy which is always good. Happy to merge if it is ready.

@philippjfr
Copy link
Member Author

Ready to merge whenever.

@jlstevens
Copy link
Contributor

Now then! :-)

jlstevens added a commit that referenced this pull request Feb 28, 2016
Fixed bug in bokeh hover tool for unsanitized dimensions
@jlstevens jlstevens merged commit e09c146 into master Feb 28, 2016
@philippjfr philippjfr deleted the hover_fix branch April 1, 2016 14:27
@philippjfr philippjfr modified the milestones: Major feature request, 1.4.4, v1.5.0 Apr 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tag: backend: bokeh type: bug Something isn't correct or isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants