Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed example of line spreading, color key, and cmap for antialiasing #5267

Merged
merged 2 commits into from
Apr 10, 2022

Conversation

jbednar
Copy link
Member

@jbednar jbednar commented Apr 8, 2022

The Large Data guide had a few issues:

  • It had been claiming that dynspread worked for paths and curves, but that hasn't been true since 6/2021 when we fixed dynspread to have reasonable behavior. Since then, any connected path will have no dynamic spreading, since all pixels have a connected neighbor. Suggested alternatives instead.
  • The fake categorical color_key example was using [0,0] as the data, which works for some reason, but I think it needs to be ([0,0]), i.e. a single point (x,y)
  • The new examples of line_width=X weren't showing antialiasing, because they had only a single color in their colormap. Added colormaps for those.
  • The seemingly valid syntax (c + m).opts(opts.RGB(width=400)) has started showing WARNING:param.main: Calling the .opts method with options broken down by options group (i.e. separate plot, style and norm groups) is deprecated., which seems like a bogus warning since the option is applied and is not broken down by options group. Silenced it by switching to c.opts(width=400) + m.opts(width=400), but that code was previously legal and presumably should not be warning.

@codecov-commenter
Copy link

codecov-commenter commented Apr 8, 2022

Codecov Report

Merging #5267 (c69d7ee) into master (7930d08) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #5267   +/-   ##
=======================================
  Coverage   86.72%   86.72%           
=======================================
  Files         299      299           
  Lines       62187    62187           
=======================================
  Hits        53929    53929           
  Misses       8258     8258           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7930d08...c69d7ee. Read the comment docs.

@philippjfr philippjfr merged commit 89ac57d into master Apr 10, 2022
philippjfr pushed a commit that referenced this pull request Apr 10, 2022
…#5267)

* Fixed example of line spreading, color key, and colormap for antialiasing

* Avoided bogus warning
@jbednar jbednar deleted the lgdatadocs branch April 10, 2022 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants