Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ibis-framework version 3 #5292

Merged
merged 3 commits into from
May 27, 2022
Merged

Support ibis-framework version 3 #5292

merged 3 commits into from
May 27, 2022

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented May 1, 2022

The change to pip is because I get some weird __version__ even though I'm on the newest release.

Screenshot from 2022-05-01 16-51-28

@codecov-commenter
Copy link

codecov-commenter commented May 1, 2022

Codecov Report

Merging #5292 (1e19557) into master (5b5b189) will decrease coverage by 0.00%.
The diff coverage is 77.77%.

@@            Coverage Diff             @@
##           master    #5292      +/-   ##
==========================================
- Coverage   86.64%   86.64%   -0.01%     
==========================================
  Files         299      299              
  Lines       62219    62227       +8     
==========================================
+ Hits        53911    53917       +6     
- Misses       8308     8310       +2     
Impacted Files Coverage Δ
holoviews/core/data/ibis.py 79.46% <77.77%> (-0.13%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b5b189...1e19557. Read the comment docs.

@philippjfr
Copy link
Member

Thanks @hoxbro, could you rebase?

@hoxbro hoxbro force-pushed the fix_ibis branch 2 times, most recently from 2ec70ad to f41c1da Compare May 27, 2022 09:59
@philippjfr philippjfr merged commit af8783d into holoviz:master May 27, 2022
@hoxbro hoxbro deleted the fix_ibis branch May 30, 2022 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants