Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 2.7 compatibility fixes #5298

Merged
merged 4 commits into from
May 5, 2022
Merged

Python 2.7 compatibility fixes #5298

merged 4 commits into from
May 5, 2022

Conversation

philippjfr
Copy link
Member

Ran most of the tests and they seem to run okay.

@jlstevens
Copy link
Contributor

Tests are mostly passing though I'm not expecting py2 to pass on CI. As py2 mostly passes locally, I'll merge once the other tests are green.

@codecov-commenter
Copy link

codecov-commenter commented May 5, 2022

Codecov Report

Merging #5298 (995ace3) into branch_1.14.9 (295011c) will increase coverage by 0.00%.
The diff coverage is 88.88%.

@@              Coverage Diff               @@
##           branch_1.14.9    #5298   +/-   ##
==============================================
  Coverage          86.48%   86.48%           
==============================================
  Files                297      297           
  Lines              62804    62809    +5     
==============================================
+ Hits               54315    54323    +8     
+ Misses              8489     8486    -3     
Impacted Files Coverage Δ
holoviews/core/layout.py 76.40% <0.00%> (ø)
holoviews/core/dimension.py 85.24% <100.00%> (+0.02%) ⬆️
holoviews/core/util.py 85.05% <100.00%> (+0.01%) ⬆️
holoviews/util/transform.py 86.02% <100.00%> (ø)
holoviews/operation/datashader.py 80.08% <0.00%> (+0.32%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 295011c...995ace3. Read the comment docs.

@jlstevens
Copy link
Contributor

3.7 has just passed on OSX and everything except the other OSX jobs have passed. Merging.

@jlstevens jlstevens merged commit 2e0255e into branch_1.14.9 May 5, 2022
@maximlt maximlt deleted the py2_compat branch June 27, 2022 00:29
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants