Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes iterable in Overlay #5320

Merged
merged 3 commits into from
Jul 15, 2022
Merged

Fixes iterable in Overlay #5320

merged 3 commits into from
Jul 15, 2022

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented May 24, 2022

Fixes #5315

@codecov-commenter
Copy link

codecov-commenter commented May 24, 2022

Codecov Report

Merging #5320 (d1a2a93) into master (c265cc1) will increase coverage by 1.33%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #5320      +/-   ##
==========================================
+ Coverage   86.74%   88.07%   +1.33%     
==========================================
  Files         299      301       +2     
  Lines       62218    61965     -253     
==========================================
+ Hits        53969    54575     +606     
+ Misses       8249     7390     -859     
Impacted Files Coverage Δ
holoviews/core/dimension.py 86.42% <100.00%> (+0.08%) ⬆️
holoviews/tests/plotting/bokeh/test_overlayplot.py 100.00% <100.00%> (+0.70%) ⬆️
holoviews/plotting/mpl/raster.py 77.70% <0.00%> (-4.33%) ⬇️
holoviews/tests/element/test_comparisonsimple.py 90.78% <0.00%> (-3.74%) ⬇️
holoviews/plotting/util.py 69.49% <0.00%> (-2.06%) ⬇️
holoviews/plotting/mpl/util.py 75.43% <0.00%> (-2.04%) ⬇️
holoviews/tests/core/data/test_ibisinterface.py 80.48% <0.00%> (-1.22%) ⬇️
holoviews/plotting/bokeh/raster.py 71.30% <0.00%> (-0.95%) ⬇️
holoviews/element/sankey.py 95.04% <0.00%> (-0.93%) ⬇️
holoviews/core/layout.py 75.60% <0.00%> (-0.81%) ⬇️
... and 97 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c265cc1...d1a2a93. Read the comment docs.

holoviews/core/dimension.py Outdated Show resolved Hide resolved
@jlstevens
Copy link
Contributor

Happy to merge once the tests pass.

@jlstevens jlstevens merged commit ad59a3f into holoviz:master Jul 15, 2022
@hoxbro hoxbro deleted the overlay_iterable branch July 16, 2022 12:17
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Overlay does not detect iterables properly
4 participants