Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hv.help when pattern is set #5330

Merged
merged 4 commits into from
Jun 7, 2022
Merged

Fix hv.help when pattern is set #5330

merged 4 commits into from
Jun 7, 2022

Conversation

maximlt
Copy link
Member

@maximlt maximlt commented Jun 7, 2022

I think this was just totally untested so the code was not being updated. I've added a minimal test.

For reference this allows to get an highlighted help if the pattern matches some text:

import holoviews as hv
hv.extension('bokeh')
hv.help(hv.Curve, pattern='border')

image

cc @jlstevens

@jlstevens
Copy link
Contributor

Looks good to me! Ready to merge?

@maximlt
Copy link
Member Author

maximlt commented Jun 7, 2022

Yep!

@jlstevens jlstevens merged commit 22db2d1 into master Jun 7, 2022
@jlstevens jlstevens deleted the fix_help_pattern branch June 7, 2022 15:09
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants