Ensure setting opts on DynamicMap does not generate deprecation warnings #5345
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
DynamicMap._style
method is responsible for applying options set on aDynamicMap
. It does so by looking up a custom options tree and then setting that on the returned object. The format of that custom options tree is broken down by the options group (i.e. 'style', 'norm' and 'plot') and then gets applied using the public.opts()
call. This is problematic because.opts
explicitly checks that options are not set using the deprecated option groups format. Therefore we bypass that call and directly apply the option groups usingopts.apply_groups
(which is what happens internally anyway).Fixes #5341