Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix colorbar error by only using finite bbox #5409

Merged
merged 1 commit into from
Aug 26, 2022

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented Aug 26, 2022

Fixes #5406

image

@hoxbro hoxbro requested a review from jlstevens August 26, 2022 10:28
@codecov-commenter
Copy link

codecov-commenter commented Aug 26, 2022

Codecov Report

Merging #5409 (29ccf90) into master (a780aeb) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #5409   +/-   ##
=======================================
  Coverage   88.07%   88.07%           
=======================================
  Files         301      301           
  Lines       61991    61991           
=======================================
  Hits        54596    54596           
  Misses       7395     7395           
Impacted Files Coverage Δ
holoviews/plotting/mpl/util.py 75.43% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jlstevens
Copy link
Contributor

Looks good to me!

Happy to merge when the remaining tests finish (ignoring the ones that timed out!)

@jlstevens jlstevens merged commit 05721f6 into holoviz:master Aug 26, 2022
@hoxbro hoxbro deleted the fix_colorbar branch August 27, 2022 09:31
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Matplotlib error on colorbar
3 participants